Skip to content

feat(l2): bench job #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat(l2): bench job #2663

wants to merge 20 commits into from

Conversation

xqft
Copy link
Contributor

@xqft xqft commented May 2, 2025

Motivation

Continously (on each push to main) prove an Ethereum Mainnet block to test and benchmark ethrex-prover.

Description

  • adds job to prove an L1 block using the bench crate
  • post the gas rate (Mgas/s) into gh pages with the github benchmark action.

@xqft xqft requested a review from a team as a code owner May 2, 2025 19:53
Copy link

github-actions bot commented May 2, 2025

Lines of code report

Total lines added: 21
Total lines removed: 0
Total lines changed: 21

Detailed view
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/l2/prover/bench/src/main.rs | 116   | +21  |
+-------------------------------------------+-------+------+

@xqft
Copy link
Contributor Author

xqft commented May 2, 2025

Successful run: https://github.com/lambdaclass/ethrex/actions/runs/14803522566/job/41567485293

TODO:

  1. Add ETHREX_L2_RPC_URL secret
  2. Add system info about runner

Base automatically changed from l2/fix_bench_2 to l2/bump_sp1 May 5, 2025 14:27
@xqft
Copy link
Contributor Author

xqft commented May 5, 2025

Another option is to cache a block, but in that case we would be omitting part of the flow and we may not catch some bugs

Base automatically changed from l2/bump_sp1 to main May 5, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant