feat(l2): integrate TDX as a prover #2777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeanSerra
reviewed
May 20, 2025
There was a problem hiding this comment.
This PR is looking good however I think we could add to the docs the following to make it easier for people new to TDX to get up and running:
- Detailed steps (with commands to run) on how to run the integration test in TDX capable hardware
- Detailed steps (with an example) on how to update the
RTMR/MRTDvalues as they change every time you rebuild the vm (mkosi vm -f).
iovoid
force-pushed
the
feat/tdx-integration
branch
from
7892adf to
438f818
Compare
jrchatruc
approved these changes
May 22, 2025
LeanSerra
approved these changes
May 22, 2025
mpaulucci
added a commit
that referenced
this pull request
May 23, 2025
**Motivation** In #2677 an example of a TDX-based prover was made. This uses the example code to add a prover. **Description** TDX is added as another prover, and made to use the same API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #2677 an example of a TDX-based prover was made. This uses the example code to add a prover.
Description
TDX is added as another prover, and made to use the same API