Skip to content

feat(l1): log warning if no CL messages are received in a while #5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(l1): log warning if no CL messages are received in a while #5256

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
991d091
Added warning for no CL messages
SDartayet Nov 10, 2025
83260af
bumped log level to error
SDartayet Nov 10, 2025
3f6c425
fix unused import
SDartayet Nov 11, 2025
2bcebc6
change back to warn from error level
SDartayet Nov 11, 2025
97a0682
simplify error message
SDartayet Nov 11, 2025
3359350
cargo fmt
SDartayet Nov 11, 2025
30d2cd4
Fix handler signature
SDartayet Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion crates/networking/rpc/rpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ use tokio::sync::{
mpsc::{UnboundedSender, unbounded_channel},
oneshot,
};
use tokio::time::timeout;
use tower_http::cors::CorsLayer;
use tracing::{error, info};
use tracing_subscriber::{EnvFilter, Registry, reload};
Expand Down Expand Up @@ -296,7 +297,24 @@ pub async fn start_api(
.into_future();
info!("Starting HTTP server at {http_addr}");

let authrpc_handler = |ctx, auth, body| async { handle_authrpc_request(ctx, auth, body).await };
let (timer_sender, mut timer_receiver) = tokio::sync::watch::channel(());

tokio::spawn(async move {
loop {
let result = timeout(Duration::from_secs(30), timer_receiver.changed()).await;
if result.is_err() {
error!("No messages from the consensus layer. Is the consensus client running?
Check the auth JWT coincides with the one used by the CL and the auth RPC address and port used by it and Ethrex match."
);
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spawned task will panic if the sender is dropped. When timer_receiver.changed() returns an error (which occurs when all senders are dropped), the code logs an error but continues looping. This will cause continuous error logging. The loop should break when changed() returns Err, which indicates the channel is closed.

Suggested change
if result.is_err() {
error!("No messages from the consensus layer. Is the consensus client running?
Check the auth JWT coincides with the one used by the CL and the auth RPC address and port used by it and Ethrex match."
);
match result {
Ok(Ok(_)) => {
// Successfully received a change, continue looping.
}
Ok(Err(_)) | Err(_) => {
error!("No messages from the consensus layer. Is the consensus client running?
Check the auth JWT coincides with the one used by the CL and the auth RPC address and port used by it and Ethrex match."
);
break;
}

Copilot uses AI. Check for mistakes.
}
}
});

let authrpc_handler = async move |ctx, auth, body| {
let _ = timer_sender.send(());
handle_authrpc_request(ctx, auth, body).await
};

let authrpc_router = Router::new()
.route("/", post(authrpc_handler))
.with_state(service_context.clone())
Expand Down