feat: distributed index building for ivf index#218
Open
goodqiang wants to merge 3 commits intolance-format:mainfrom
Open
feat: distributed index building for ivf index#218goodqiang wants to merge 3 commits intolance-format:mainfrom
goodqiang wants to merge 3 commits intolance-format:mainfrom
Conversation
github-actions
bot
added
enhancement
jackye1995
reviewed
Feb 11, 2026
| Dataset.open() | ||
| .allocator(LanceRuntime.allocator()) | ||
| .namespace(readOptions.getNamespace) | ||
| .readOptions(readOptions.toReadOptions) |
Contributor
There was a problem hiding this comment.
this should not be removed
jackye1995
reviewed
Feb 11, 2026
| import java.util.*; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class BaseVectorIndexTest extends BaseAddIndexTest { |
Contributor
There was a problem hiding this comment.
this test is not really inheriting anything from BaseAddIndexTest?
jackye1995
reviewed
Feb 11, 2026
pom.xml
Outdated
| <properties> | ||
| <lance-spark.version>0.2.0</lance-spark.version> | ||
| <lance.version>2.0.0</lance.version> | ||
| <lance.version>3.0.0-beta.2</lance.version> |
Contributor
There was a problem hiding this comment.
do we depend on any feature not in 2.0?
jackye1995
reviewed
Feb 11, 2026
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
thanks for the work! Please also add related documentations, and make sure CI is passing 🙏
hamersaw
reviewed
Feb 12, 2026
Collaborator
hamersaw
left a comment
hamersaw
left a comment
There was a problem hiding this comment.
Can we add a small integration test in docker/tests/test_lance_spark.py?
Collaborator
|
Looks like there are a few integration test failures, can you fix those? The logs are extremely verbose making it difficult to discover the root cause, I'm wondering if we can reduce the log-level so they're more easily digested? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: distributed index building for ivf index support #176
BREAKING CHANGE: AddIndexExec adds "alter table create index index_name using ivf_flat/ivf_pq/ivf_sq"