resolve comments

Author: mdrxy

libs/core/langchain_core/messages/content_blocks.py

@@ -1309,8 +1309,7 @@ def create_tool_call(
 
 
 def create_reasoning_block(
-    reasoning: str,
-    *,
+    reasoning: Optional[str] = None,
     id: Optional[str] = None,
     index: Optional[int] = None,
 ) -> ReasoningContentBlock:
@@ -1331,7 +1330,7 @@ def create_reasoning_block(
     """
     block = ReasoningContentBlock(
         type="reasoning",
-        reasoning=reasoning,
+        reasoning=reasoning or "",
         id=_ensure_id(id),
     )
 

libs/core/langchain_core/messages/v1.py

@@ -10,7 +10,7 @@
 from typing import Any, Literal, Optional, Union, cast, get_args
 
 from pydantic import BaseModel
-from typing_extensions import NotRequired, TypedDict
+from typing_extensions import TypedDict
 
 import langchain_core.messages.content_blocks as types
 from langchain_core.messages.ai import (
@@ -54,10 +54,10 @@ class ResponseMetadata(TypedDict, total=False):
     definition.
     """
 
-    model_provider: NotRequired[str]
+    model_provider: str
     """Name and version of the provider that created the message (e.g., openai)."""
 
-    model_name: NotRequired[str]
+    model_name: str
     """Name of the model that generated the message."""
 
 

libs/core/tests/unit_tests/test_messages.py

@@ -360,7 +360,7 @@ def test_chat_message_chunks() -> None:
     ):
         ChatMessageChunk(role="User", content="I am") + ChatMessageChunk(
             role="Assistant", content=" indeed."
-        )  # type: ignore[reportUnusedExpression, unused-ignore]
+        )  # type: ignore[reportUnusedExpression]
 
     assert ChatMessageChunk(role="User", content="I am") + AIMessageChunk(
         content=" indeed."