Skip to content

fix(core): unblock packaging dependency #32004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

fix(core): unblock packaging dependency #32004

wants to merge 5 commits into from

Conversation

ntjohnson1
Copy link
Contributor

@ntjohnson1 ntjohnson1 commented Jul 13, 2025 •
edited
Loading

Description:

  • Moves packaging to a test only dependency to avoid install collisions conceptually
  • Bumps packaging to <26 (since tests and things run with 25), could alternatively unpin since its not clear from the original commit exactly why the upperbound was required
  • Deduplicates the version specifier to match other projects in the monorepo (because I hit this when double checking things locally)
    • This ended up touching a few more things than expected and I can separate out if for any reason it is more controversial than it appears

Issue: #32003

@ntjohnson1 ntjohnson1 requested a review from eyurtsev as a code owner July 13, 2025 11:21
@vercel Vercel
Copy link

vercel bot commented Jul 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 2:50pm

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 13, 2025 •
edited
Loading

CodSpeed WallTime Performance Report

Merging #32004 will not alter performance

Comparing rerun-io:nick/core_packaging (6701fb7) with master (d57216c)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

@ntjohnson1 ntjohnson1 changed the title core: Unblock packaging dependency fix(core): Unblock packaging dependency Jul 13, 2025
@ntjohnson1 ntjohnson1 changed the title fix(core): Unblock packaging dependency fix(core): unblock packaging dependency Jul 13, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 13, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #32004 will not alter performance

Comparing rerun-io:nick/core_packaging (6701fb7) with master (d57216c)

Summary

✅ 14 untouched benchmarks

@ntjohnson1 ntjohnson1 mentioned this pull request Jul 13, 2025
Open
@eyurtsev eyurtsev self-assigned this Jul 14, 2025
eyurtsev
eyurtsev reviewed Jul 14, 2025
View reviewed changes
libs/core/langchain_core/version.py Outdated
@@ -1,3 +1,3 @@
"""langchain-core version information and utilities."""

VERSION = "0.3.68"
__version__ = "0.3.68"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this change been made?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking API change -- we don't want to make this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allowed the pyproject to determine the version automatically so that it didn't have to be tracked in two places but retained the import performance requirements. Not critical to the packaging pinning issues that was the motivation for the PR, so I reverted.

When I was testing it locally I changed the version in the pyproject but the imported version didn't change which was unexpected so I tried to centralize.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK we'll likely make this fix separately

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @sydney-runkle

@eyurtsev
Copy link
Collaborator

Could you allow maintainers to update this PR?

eyurtsev
eyurtsev reviewed Jul 14, 2025
View reviewed changes
libs/core/pyproject.toml
@@ -39,6 +38,7 @@ dev = [
"grandalf<1.0,>=0.8",
]
test = [
"packaging<26,>=23.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be moved into the test group. It's an explicit dependency of langchain_core

@eyurtsev
Copy link
Collaborator

I'll take over and make a separate PR to unblock

@eyurtsev eyurtsev closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev left review comments

@baskaryan baskaryan Awaiting requested review from baskaryan

@ccurme ccurme Awaiting requested review from ccurme

Assignees

@eyurtsev eyurtsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntjohnson1 @eyurtsev