fix(openai): ainvoke uses async _aget_response; add async tests
#32459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests for completed and requires_action paths (fixes langchain-ai#32398)
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
CodSpeed WallTime Performance ReportMerging #32459 will not alter performanceComparing
|
vineethkumarrao
changed the title
CodSpeed Instrumentation Performance ReportMerging #32459 will not alter performanceComparing Summary
|
…of direct assignment; drop unused type: ignore
mdrxy
changed the title
_aget_response; add async tests
ccurme
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where OpenAIAssistantRunnable.ainvoke called sync _get_response instead of async _aget_response.
Adds async unit tests covering:
completed run (as_agent=False) returns messages via async list
requires_action (as_agent=True) returns OpenAIAssistantAction
References: #32398