fix(core): resolve infinite recursion in _dereference_refs_helper with mixed $ref objects
#32578
+480
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
CodSpeed WallTime Performance ReportMerging #32578 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #32578 will not alter performanceComparing Summary
|
7 tasks
mdrxy
changed the title
_dereference_refs_helper with mixed $ref objects
mdrxy
added
core
…h mixed $ref objects Fixes infinite recursion issue in JSON schema dereferencing when objects contain both $ref and other properties (e.g., nullable, description, additionalProperties). **Problem:** - Commit fb5da83 changed the condition from `set(obj.keys()) == {"$ref"}` to `"$ref" in set(obj.keys())` - This caused objects with $ref + other properties to be treated as pure $ref nodes - Result: other properties were lost and infinite recursion occurred with complex schemas **Solution:** - Restore pure $ref detection for objects with only $ref key - Add proper handling for mixed $ref objects that preserves all properties - Merge resolved reference content with other properties - Maintain cycle detection to prevent infinite recursion **Impact:** - Fixes Apollo MCP server schema integration (langchain-ai#32511) - Resolves tool binding infinite recursion with complex GraphQL schemas - Preserves backward compatibility with existing functionality - No performance impact - actually improves handling of complex schemas Fixes langchain-ai#32511
eyurtsev
force-pushed
the
fix/core-json-schema-infinite-recursion-32511
branch
from
142771d to
99d6684
Compare
eyurtsev
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes infinite recursion issue in JSON schema dereferencing when objects contain both $ref and other properties (e.g., nullable, description, additionalProperties). This was causing Apollo MCP server schemas to hang indefinitely during tool binding.
Problem:
set(obj.keys()) == {"$ref"}to"$ref" in set(obj.keys())Solution:
Impact:
Issue: Fixes #32511
Dependencies: None
Testing:
Verification:
make format- All files properly formattedmake lint- All linting checks passmake test- All 1326 unit tests pass