Skip to content

Conversation

Mdzub7
Copy link

@Mdzub7 Mdzub7 commented Aug 21, 2025

Context

  • Adds two regression tests for JSON Schema dereferencing:
    1. Three-node mixed-$ref cycle (A→B→C→A) ensuring termination and sibling metadata retention.
    2. allOf + $ref composition to ensure dereferencing preserves sibling parts.

Why

Notes

Refs

@Mdzub7 Mdzub7 requested a review from eyurtsev as a code owner August 21, 2025 18:09
Copy link

vercel bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Aug 21, 2025 6:09pm

Copy link

codspeed-hq bot commented Aug 21, 2025

CodSpeed WallTime Performance Report

Merging #32643 will not alter performance

Comparing Mdzub7:tests/json-schema-recursion-regressions-32511 (5f8f776) with master (b825f85)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Aug 21, 2025

CodSpeed Instrumentation Performance Report

Merging #32643 will not alter performance

Comparing Mdzub7:tests/json-schema-recursion-regressions-32511 (5f8f776) with master (b825f85)

Summary

✅ 14 untouched benchmarks

@mdrxy mdrxy changed the title tests(core): add regression tests for dereference_refs cycles and all… test(core): add regression tests for dereference_refs cycles and all… Aug 21, 2025
@mdrxy mdrxy added investigate Flagged for investigation core Related to the package `langchain-core` labels Aug 21, 2025
@eyurtsev
Copy link
Collaborator

eyurtsev commented Sep 11, 2025

Added more unit tests in the PR: #32578

@eyurtsev eyurtsev closed this Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to the package `langchain-core` investigate Flagged for investigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants