feat(ollama): v1 message format support #32644
Draft
+6,976
−933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0ddab9f.
re: #32589 cc: @ccurme - Rename namespace: `messages.content_blocks` -> `messages.content` - Prefixes and ID logic are now in `messages.common` instead of `AIMessage` since the logic is shared between messages and message content. Did this instead of `utils` due to circular import problems that were hairy
Put in `core.utils` this time to prevent other circular import issues present in the `normalize()` rfc: `base` imports `content` `content` imports `ensure_id()` from `base`
…ders (#32602) Extensible registry system for translating AI message content blocks from various model providers. Refactors the way provider-specific content is handled, moving from hardcoded logic to a plugin-like architecture.
# Conflicts: # libs/core/langchain_core/messages/ai.py
… IDs from messages (#32572) > [!WARNING] > **BREAKING:** Simplifies message normalization to single consistent path, requiring partner package updates **Key Changes:** - Consistent multimodal handling: - OpenAI `image_url` blocks pass through unchanged (broad compatibility) - OpenAI `input_audio` and `file` blocks convert to v1 standard equivalents - Legacy v0 multimodal blocks convert to v1 standard - Everything else passes through unchanged - Partner packages must update content block parsing logic **Partner Updates** `output_version` affects how messages are serialized into `.content`. `_normalize_messages()` will now upgrade v0 content to v1, so, all partners now receive v1 format input regardless of `output_version`. Migration: - Partner packages must update to handle v1 input content blocks - `output_version` still controls serialization format of responses (unchanged) --------- Co-authored-by: Chester Curme <chester.curme@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
CodSpeed WallTime Performance ReportMerging #32644 will degrade performances by 29.8%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ❌ | test_import_time[HumanMessage] |
211.8 ms | 301.7 ms | -29.8% |
Footnotes
CodSpeed Instrumentation Performance ReportMerging #32644 will degrade performances by 60.46%Comparing Summary
Benchmarks breakdown
Footnotes |
mdrxy
added
the
codspeed-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO