Skip to content

feat(core): Make description in tools optional (supported by some vendors) #32898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(core): Make description in tools optional (supported by some vendors) #32898

wants to merge 2 commits into from
+22 −23

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Sep 11, 2025 •
edited
Loading

  • Make the description in tools optional
  • Not ready for merge, verifying using standard tests which standard tests pass with optional description

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Sep 11, 2025 6:15pm

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 11, 2025 •
edited
Loading

CodSpeed WallTime Performance Report

Merging #32898 will not alter performance

Comparing eugene/optional_description (ee6369c) with master (fca1aaa)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 11, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #32898 will not alter performance

Comparing eugene/optional_description (ee6369c) with master (fca1aaa)

Summary

✅ 14 untouched

@eyurtsev eyurtsev marked this pull request as draft September 11, 2025 18:15
@mdrxy mdrxy added the core Related to the package `langchain-core` label Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Related to the package `langchain-core`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyurtsev @mdrxy