feat: add batching to create_examples #2047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacoblee93
reviewed
Oct 2, 2025
EugeneJinXin
commented
Oct 8, 2025
| "aliveStatusCodes": [429, 200], | ||
| "ignorePatterns": [ | ||
| { | ||
| "pattern": "^https://www\\.npmjs\\.com/" |
There was a problem hiding this comment.
just to fix ci/cd failure that complains langsmith npm link returns 403, not our fault
EugeneJinXin
commented
Oct 9, 2025
| response = client.create_examples(dataset_name="agent-qa", examples=examples) | ||
| # -> {"example_ids": [... | ||
| """ # noqa: E501 | ||
| if not 1 <= max_concurrency <= 3: |
There was a problem hiding this comment.
think @validate_call pydantic runtime is ugly, so i prefer this since it works as simple and effective runtime check
jacoblee93
reviewed
Oct 9, 2025
jacoblee93
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LS-4410
Problem: Enhance upload examples performance, devX and reduce chances of hitting the current 25MB max payload limit on our backend.
Solution: size-based batching with conservative concurrency allowed (max concurrency <= 4); use
_estimate_example_sizehelper to estimate size, and depending on the concurrency we trigger sequential upload or multi-threading concurrency upload.Tests: