Skip to content

Conversation

@Kekos
Copy link

@Kekos Kekos commented Jan 25, 2022

When math_eval() is given an invalid math expression, the MathParser package returns a null AST. This PR changes the behaviour by throwing an InvalidExpression exception instead which make it catchable.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 23

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 21: 0.0%
Covered Lines: 13
Relevant Lines: 13

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 23

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 21: 0.0%
Covered Lines: 13
Relevant Lines: 13

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 23

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 21: 0.0%
Covered Lines: 13
Relevant Lines: 13

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 23

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 21: 0.0%
Covered Lines: 13
Relevant Lines: 13

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants