Skip to content

Commit 0ba7c6b

Browse files
committed
Handle kill signals manually only when inside docker to avoid issues with watcher reload in development
1 parent 449bdf3 commit 0ba7c6b

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ RUN poetry install --only main --all-extras
1717
COPY langevals/ langevals/
1818
RUN PYTHONPATH="." poetry run python langevals/server.py --preload
1919

20+
ENV RUNNING_IN_DOCKER=true
21+
2022
COPY . .
2123

2224
CMD PYTHONPATH="." poetry run python langevals/server.py

langevals/server.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ def handle_sigterm(signum, frame):
3030

3131
@asynccontextmanager
3232
async def lifespan(app: FastAPI):
33-
signal.signal(signal.SIGTERM, handle_sigterm)
34-
signal.signal(signal.SIGINT, handle_sigterm)
33+
if os.getenv("RUNNING_IN_DOCKER"):
34+
signal.signal(signal.SIGTERM, handle_sigterm)
35+
signal.signal(signal.SIGINT, handle_sigterm)
3536
yield
3637

3738

0 commit comments

Comments
 (0)