Draft: Fixes to jtlaune/nu-disk #52
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensity from cgs to problem units
Convert dust params from cgs
Update singularity-eos
…ally with install_name_tool
…nts. Have base unit specifiers be built on top of preset base values
Add temperature to units and have units aware EOS
Fix rebound on mac
Convert radiation problems to cgs
BugFix for sinks
|
I changed this to point into JT's branch, rather than develop. You two can iterate together on his branch and when that's ready we can consider merging into develop |
pdmullen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is the same goal/feature as branch jtlaune/nu-disk. I fixed some bugs in the original branch.
Description of Changes
Checklist