Caching Geometry

[adamdempsey90]

Background

Stores the used geometric entities in a pack. This no longer needs an update to parthenon. Testing looks good so far.

Description of Changes

All of our commonly used coordinate variables are now Metadata::none fields. Because they have different storage than our normal fields, our coords object now provides an index into these fields. The two ways to get e.g., the centroid are now:

const auto &xv = coords.GetCellCenter();  // do not use the cache
const auto &xv = coords.GetCellCenter(vg, b, k, j, i);  // use the cache

You don't have to use the cached approach, the old methods all still work and are needed in some places. There are also some places where I've opted not to change to cached coords, but that may change in the future.

Checklist

• New features are documented
• Tests added for bug fixes and new features
• (@lanl.gov employees) Update copyright on changed files

[adamdempsey90]

Tests now pass for real and I'm seeing similar performance b/w 3D cartesian and spherical for the blast wave.

[adamdempsey90]

CI errors are all hdf5 related. I wonder if I can't put Metadata::None into a restart file?

[adamdempsey90]

CI errors are all hdf5 related. I wonder if I can't put Metadata::None into a restart file?

Removing Metadata::Restart from them, seems to have fixed the issue

[adamdempsey90]

I had to revert all of the caching in the BC functions since there was some indexing/size related error for the coarse buffer. These + the prlongation/restriction operators will have to wait until parthenon supports caching.