Skip to content

Conversation

rbberger
Copy link
Collaborator

@rbberger rbberger commented Sep 3, 2024

PR Summary

This updates the re-git CI to make use of a new deployment upstream.

It also simplifies the CI configuration by using scripts to drive the build and testing.

Each re-git CI job now displays a message at the beginning of the job on how to reproduce the same build on a given cluster.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your hard work on this @rbberger ! A minor request about docs below. Otherwise merge when ready.

Also maybe let's make an issue regarding the long compile times (and thus the disabled CI) for the closure builds so we keep track of that.

Comment on lines +103 to +116
# currently disabled due to very long compilation times
#openmpi_fortran_cuda_gcc_ampere:
# extends: [.ascgit_job, .darwin_job, .report_tests, .build_and_test]
# needs: [download_prereq]
# variables:
# SPACK_ENV_NAME: openmpi-fortran-cuda-gcc-ampere
# SCHEDULER_PARAMETERS: "-N 1 --qos=debug -p shared-gpu-ampere"
#
#openmpi_fortran_cuda_gcc_volta:
# extends: [.ascgit_job, .darwin_job, .report_tests, .build_and_test]
# needs: [download_prereq]
# variables:
# SPACK_ENV_NAME: openmpi-fortran-cuda-gcc-volta
# SCHEDULER_PARAMETERS: "-N 1 --qos=debug -p volta-x86 -C cpu_family:haswell"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline---after this is merged in, maybe next FY when we have human-cycles, we need to find a way to get these running in reasonable amounts of time.

@Yurlungur Yurlungur merged commit 4e56066 into main Sep 4, 2024
5 checks passed
@Yurlungur Yurlungur deleted the use_xcap_spack_env branch September 4, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants