Skip to content

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

In #504 I merged some incorrect text. This resolves those inconsistencies.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur requested a review from jhp-lanl May 28, 2025 16:17
@Yurlungur Yurlungur self-assigned this May 28, 2025
@Yannicked
Copy link
Contributor

The docs are also missing the split parameter from #502

@Yurlungur
Copy link
Collaborator Author

The docs are also missing the split parameter from #502

Fixed

@Yurlungur
Copy link
Collaborator Author

@jhp-lanl please review when you get a chance. Pretty trivial MR.

@Yurlungur Yurlungur added documentation Improvements or additions to documentation clean-up Changes that don't affect code execution but make the code cleaner labels Jun 8, 2025
@Yurlungur
Copy link
Collaborator Author

@jhp-lanl reminder to please review

Copy link
Collaborator

@jhp-lanl jhp-lanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Yurlungur Yurlungur merged commit c142562 into main Sep 8, 2025
9 checks passed
@Yurlungur Yurlungur deleted the jmm/cleanup-fortran-docs branch September 8, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-up Changes that don't affect code execution but make the code cleaner documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants