Skip to content

Conversation

jhp-lanl
Copy link
Collaborator

PR Summary

@jonahm-LANL @Yurlungur added a change to how the SpinerEOS* classes handle density guesses for a given pressure and temperature.

This fixed a test issue I was encountering in #526 where the results were not reproducible when doing the lookup from several different places.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@jhp-lanl
Copy link
Collaborator Author

Tests pass. Merging without review since I'm not actually the author 😅

@jhp-lanl jhp-lanl merged commit 69f3c6f into main Sep 17, 2025
9 checks passed
@jhp-lanl jhp-lanl deleted the jmm/rhopmin-in-spiner branch September 17, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants