SetRhoPMin shouldn't be a host device function

[Yurlungur]

PR Summary

PR Checklist

Eliminates a warning on GPU builds. This function never should have been a host device function.

• Adds a test for any bugs fixed. Adds tests for new features.
• Format your changes by using the make format command after configuring with cmake.
• Document any new features, update documentation for changes made.
• Make sure the copyright notice on any files you modified is up to date.
• After creating a pull request, note it in the CHANGELOG.md file.
• LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

• Update the version in cmake.
• Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
• Ensure that any when='@main' dependencies are updated to the release version in the package.py

[jhp-lanl]

@jonahm-LANL @Yurlungur in case you didn't already see:

In file included from /home/runner/work/singularity-eos/singularity-eos/singularity-eos/eos/get_sg_eos_rho_p.cpp:16:
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/closure/mixed_cell_models.hpp: In instantiation of ‘Real singularity::mix_impl::sum_neumaier(Data_t&&, std::size_t, std::size_t, int, const Operator_t&) [with Data_t = double*&; Operator_t = IdentityOperator; Real = double; std::size_t = long unsigned int]’:
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/closure/mixed_cell_models.hpp:335:29:   required from ‘void singularity::mix_impl::PTESolverBase<EOSIndexer, RealIndexer, LambdaIndexer>::InitRhoBarandRho() [with EOSIndexer = singularity::EOSAccessor_; RealIndexer = double*; LambdaIndexer = singularity::mix_impl::CacheAccessor]’
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/closure/mixed_cell_models.hpp:1640:27:   required from ‘Real singularity::PTESolverFixedP<EOSIndexer, RealIndexer, LambdaIndexer>::Init() [with EOSIndexer = singularity::EOSAccessor_; RealIndexer = double*; LambdaIndexer = singularity::mix_impl::CacheAccessor; Real = double]’
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/closure/mixed_cell_models.hpp:2077:15:   required from ‘singularity::SolverStatus singularity::PTESolver(System&) [with System = PTESolverFixedP<EOSAccessor_, double*, mix_impl::CacheAccessor>]’
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/eos/get_sg_eos_rho_p.cpp:70:34:   required from here
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/closure/mixed_cell_models.hpp:230:11: error: comparison of integer expressions of different signedness: ‘std::size_t’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
  230 |     if (i == iskip) continue;
      |         ~~^~~~~~~~

[Yurlungur]

@jonahm-LANL @Yurlungur in case you didn't already see:

In file included from /home/runner/work/singularity-eos/singularity-eos/singularity-eos/eos/get_sg_eos_rho_p.cpp:16:
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/closure/mixed_cell_models.hpp: In instantiation of ‘Real singularity::mix_impl::sum_neumaier(Data_t&&, std::size_t, std::size_t, int, const Operator_t&) [with Data_t = double*&; Operator_t = IdentityOperator; Real = double; std::size_t = long unsigned int]’:
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/closure/mixed_cell_models.hpp:335:29:   required from ‘void singularity::mix_impl::PTESolverBase<EOSIndexer, RealIndexer, LambdaIndexer>::InitRhoBarandRho() [with EOSIndexer = singularity::EOSAccessor_; RealIndexer = double*; LambdaIndexer = singularity::mix_impl::CacheAccessor]’
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/closure/mixed_cell_models.hpp:1640:27:   required from ‘Real singularity::PTESolverFixedP<EOSIndexer, RealIndexer, LambdaIndexer>::Init() [with EOSIndexer = singularity::EOSAccessor_; RealIndexer = double*; LambdaIndexer = singularity::mix_impl::CacheAccessor; Real = double]’
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/closure/mixed_cell_models.hpp:2077:15:   required from ‘singularity::SolverStatus singularity::PTESolver(System&) [with System = PTESolverFixedP<EOSAccessor_, double*, mix_impl::CacheAccessor>]’
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/eos/get_sg_eos_rho_p.cpp:70:34:   required from here
/home/runner/work/singularity-eos/singularity-eos/singularity-eos/closure/mixed_cell_models.hpp:230:11: error: comparison of integer expressions of different signedness: ‘std::size_t’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
  230 |     if (i == iskip) continue;
      |         ~~^~~~~~~~

yep fixed

[jhp-lanl]

Merge when ready