Skip to content

SetRhoPMin shouldn't be a host device function #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2025
Merged

SetRhoPMin shouldn't be a host device function #571

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55a6ba3
SetRhoPMin shouldn't be a host device function
jonahm-LANL Sep 25, 2025
81aee51
inline
jonahm-LANL Sep 25, 2025
66e6b9a
mixed cell models sign comparison
jonahm-LANL Sep 25, 2025
97de101
comparison
jonahm-LANL Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion singularity-eos/closure/mixed_cell_models.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ struct IdentityOperator {
};
template <typename Data_t, typename Operator_t = IdentityOperator>
PORTABLE_FORCEINLINE_FUNCTION Real
sum_neumaier(Data_t &&data, std::size_t n, std::size_t offset = 0, std::size_t iskip = -1,
sum_neumaier(Data_t &&data, std::size_t n, std::size_t offset = 0, int iskip = -1,
const Operator_t &op = IdentityOperator()) {
Real sum = 0;
Real c = 0; // correction
Expand Down
6 changes: 2 additions & 4 deletions singularity-eos/eos/eos_spiner_common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,8 @@ PORTABLE_FORCEINLINE_FUNCTION Real from_log(const Real lx, const Real offset) {
return FastMath::pow10(lx) - offset;
}

PORTABLE_INLINE_FUNCTION Real SetRhoPMin(DataBox &P, DataBox &rho_at_pmin,
const bool pmin_vapor_dome,
const Real VAPOR_DPDR_THRESH,
const Real lRhoOffset) {
inline Real SetRhoPMin(DataBox &P, DataBox &rho_at_pmin, const bool pmin_vapor_dome,
const Real VAPOR_DPDR_THRESH, const Real lRhoOffset) {
Real PMin = std::numeric_limits<Real>::max();
const auto lTs = P.range(0);
const auto lRs = P.range(1);
Expand Down
Loading