Skip to content

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Oct 2, 2025

The last time the GPU compatibility patch was updated for HIP, it was only updated in the spackage, not the version used for in-tree builds. Probably we should centralize it so there's only one location, rather than three copies floating around. For now, though, I just copy the one in the spackage into the location used by cmake for in-tree builds.

PR Summary

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur requested a review from rbberger October 2, 2025 22:41
@Yurlungur Yurlungur self-assigned this Oct 2, 2025
@Yurlungur
Copy link
Collaborator Author

Yurlungur commented Oct 2, 2025

This was required to get in-tree builds working on rzadams

@Yurlungur
Copy link
Collaborator Author

This MR is not correct. Will try to figure out what's going on

@Yurlungur Yurlungur closed this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants