Skip to content

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

Just a little bit of cleanup moving from older style headers to the C++ wrappers in std namespace

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur self-assigned this Oct 8, 2025
@Yurlungur Yurlungur added the clean-up Changes that don't affect code execution but make the code cleaner label Oct 8, 2025
@Yurlungur Yurlungur changed the title move away from older style headers [Trivial] move away from older style headers Oct 8, 2025
@mauneyc-LANL mauneyc-LANL merged commit 99ffa7f into main Oct 9, 2025
9 checks passed
@mauneyc-LANL mauneyc-LANL deleted the jmm/its-called-cmath branch October 9, 2025 13:18
@jhp-lanl
Copy link
Collaborator

There's a missing std::isnan in compare_to_eospac.cpp

@Yurlungur Yurlungur mentioned this pull request Oct 10, 2025
9 tasks
@Yurlungur
Copy link
Collaborator Author

There's a missing std::isnan in compare_to_eospac.cpp

#578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-up Changes that don't affect code execution but make the code cleaner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants