Skip to content

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

My recent cleanup #576 broke the CI by pulling some math.h functions out of public namespace. This MR should hopefully resolve the issue.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur added the bug Something isn't working label Oct 10, 2025
@jhp-lanl
Copy link
Collaborator

This appears to fix the issues we were seeing in the gitlab CI. I'm merging since the remaining CI jobs weren't affected and are hung at the batch submission stage (so they'll likely fail anyway).

@jhp-lanl jhp-lanl merged commit 2061678 into main Oct 10, 2025
9 checks passed
@jhp-lanl jhp-lanl deleted the jmm/cmath-hotfix branch October 10, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants