Skip to content

Conversation

johnatricorocks
Copy link
Contributor

This PR is an update to use Adaptive Cards as proposed in issue
#31

@Tob0t
Copy link
Collaborator

Tob0t commented Mar 1, 2025

Thanks for your contribution, I'm willing to merge this, but before we need to consider two more things:

  • please resolve the merge conflict in the readme (there was an unfortunate update to the readme this week, you can accept the majority of the changes from your readme updates), if this is too cumbersome, please give me write access on your PR, and I can resolve it (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
  • since this introduces a breaking change, we will need to release a new major version and provide an upgrade path: since I'm not actively using this package anymore, could you maybe provide some instructions what you needed to change, so we can document it? Are there any things which needs to be considered when using the adaptive card which is not possible anymore?

Thanks again for your effort, because of people like you we can keep open-source alive 🙇

->notify(new SubscriptionCreated());
```

### Available Adaptive Card methods
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflict here, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This merge conflict has now been resolved

@johnatricorocks
Copy link
Contributor Author

@Tob0t As it is a breaking change, should we take the opportunity to only support PHP >8.1 or 8.2

@johnatricorocks
Copy link
Contributor Author

@Tob0t Update notes and instructions have been added

@nzwz
Copy link

nzwz commented Apr 1, 2025

Hi @Tob0t, Is there a schedule to merge this PR? We’re looking forward to starting with Adaptive Cards and contributing more interesting features.

@Tob0t
Copy link
Collaborator

Tob0t commented Apr 3, 2025

Hi @nzwz,
the last months have been busy 🙈
I plan to merge this PR this weekend and create a pre-release since I have not yet found time to test the migration properly. As soon as I have time to do this, I'll create a proper release.
The timeline is the end of April/start of May.

@Tob0t Tob0t self-assigned this Apr 3, 2025
@ChrisToxz
Copy link

Two questions:

Copy link
Collaborator

@Tob0t Tob0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort 👍

@Tob0t
Copy link
Collaborator

Tob0t commented Apr 26, 2025

Two questions:

Yes, let's go for >= 8.1 and then we can use Enums, feel free to create a follow up PR

@Tob0t Tob0t merged commit ab01aad into laravel-notification-channels:master Apr 26, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants