You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was trying to add TransactionCommitting event (introduced in 9.36.4) to laravel-spanner and noticed that it is only executed when transaction level is at 1 but TransactionBegan and TransactionCommitted event is triggered regardless of transaction level.
Shouldn't TransactionCommitting performed the same as other transaction events?
I wanted to ask before I make a fix PR, since this will be a breaking change and didn't know if it was worth breaking existing code.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I was trying to add
TransactionCommitting
event (introduced in 9.36.4) to laravel-spanner and noticed that it is only executed when transaction level is at1
butTransactionBegan
andTransactionCommitted
event is triggered regardless of transaction level.Shouldn't
TransactionCommitting
performed the same as other transaction events?I wanted to ask before I make a fix PR, since this will be a breaking change and didn't know if it was worth breaking existing code.
Beta Was this translation helpful? Give feedback.
All reactions