Validator::validate() and Validator::valid() not returning the same output

[bluesheep100]

Validator::validate() and Validator::valid() do not return the same list of valid data.
Validator::validate() returns only the data that has passed a validation rule.
Validator::valid() ALL data that did not explicitly fail a validation rule.

Example:

$data = ['foo' => 'bar', 'buzz' => 'foobar'];
$rules = ['foo' => 'required|in:bar,baz'];
dd(
    \Validator::make($data, $rules)->validate(),
    \Validator::make($data, $rules)->valid(),
);

// ['foo' => 'bar']
// ['foo' => 'bar', 'buzz' => 'foobar']

Is this intentional? I can't seem to find anything about the fact that Validator::valid() returns unvalidated data in the docs.

I discovered this difference in behaviour, because of an autosave feature, where it saves all of the fields to a JSON object (cast to/from a DTO-type class via a custom cast, but saved as JSON) and it needs to be able to save every valid field, regardless of how many are invalid. Currently I rely on some pretty sketchy workarounds to make it not save unvalidated data.

[macropay-solutions]

    /**
     * Returns the data which was valid.
     *
     * @return array
     */
    public function valid()
    {
        if (! $this->messages) {
            $this->passes();
        }

        return array_diff_key(
            $this->data, $this->attributesThatHaveMessages()
        );
    }

    /**
     * Run the validator's rules against its data.
     *
     * @return array
     *
     * @throws \Illuminate\Validation\ValidationException
     */
    public function validate()
    {
        throw_if($this->fails(), $this->exception, $this);

        return $this->validated();
    }

You can use validated()

Example of FormRequest used without autowiring.

[macropay-solutions]

This #55736 (reply in thread) does not throw (the fails() does not throw).

[bluesheep100]

The problem is that Validator::validated() will in fact still throw, because what I need is to receive the data, validate it, extract the data was validated successfully, save only that, and then return a redirect as normal.
I do not want to redirect, or to throw any exception, if a validation error occurs, and as far as I can tell, this is not possible with standard Laravel, as valid() doesn't behave the same as validate(), validated(), and safe() (which just calls $this->validated() internally anyway), and the latter all throw exceptions.
I need specifically this behaviour:

// Make validator
$v = \Validator::make(['buzz' => 'foobar'], ['foo' => 'required|in:bar,baz']);

// Validate input, WITHOUT throwing
$validData = $v->validateWithoutThrowing();

// Regular redirect response
return to_route('index');

And I am still wanting to hear from someone whether the difference in output between Validator::valid() and Validator::validate() is intentional, as it really looks like a bug, to me.

[macropay-solutions]

So, you want the valid data only, even if some fields failed validation.

[bluesheep100]

Yes.. That's what I said from the beginning.

[macropay-solutions]

That is a partially valid not valid. That is what took us on the wrong path.