[12.x] PHP 8.5 Compatibility: Detect Pdo\Mysql::ATTR_SSL_CA via defined() rather than PHP version#57866
Closed
onlime wants to merge 1 commit into
Closed
[12.x] PHP 8.5 Compatibility: Detect Pdo\Mysql::ATTR_SSL_CA via defined() rather than PHP version#57866onlime wants to merge 1 commit into
Pdo\Mysql::ATTR_SSL_CA via defined() rather than PHP version#57866onlime wants to merge 1 commit into
Conversation
Member
|
We don't need this. As explained in the PR that is temporarily until symfony/polyfill#549 get merged. The only reason the changes was made in the framework and not skeleton is only to allow our team to update 1st party packages to be tested with PHP 8.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #57835. That PR used a
PHP_VERSION_ID >= 80500check, but this can fail on minimal or custom PHP installations where thePdo\Mysqldriver-specific PDO subclass is not available.As recommended by @phildawson-gravity in #57141 (comment), feature-detection is more reliable. This update switches the condition to
defined('Pdo\Mysql::ATTR_SSL_CA'), ensuring compatibility across environments regardless of how PDO extensions are compiled.Behavior of different PHP versions: