Skip to content

Commit 79eebde

Browse files
Fix code styling
1 parent 8196a78 commit 79eebde

File tree

7 files changed

+54
-53
lines changed

7 files changed

+54
-53
lines changed

app/Filament/Actions/ApprovedAction.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace App\Filament\Actions;
46

57
use Filament\Actions\Concerns\CanCustomizeProcess;
6-
use Filament\Support\Facades\FilamentIcon;
78
use Illuminate\Database\Eloquent\Model;
89

9-
class ApprovedAction extends \Filament\Tables\Actions\Action
10+
final class ApprovedAction extends \Filament\Tables\Actions\Action
1011
{
1112
use CanCustomizeProcess;
13+
1214
public static function getDefaultName(): ?string
1315
{
1416
return 'approved';
@@ -28,7 +30,7 @@ protected function setUp(): void
2830

2931
$this->color('success');
3032

31-
$this->icon( 'heroicon-s-x-mark');
33+
$this->icon('heroicon-s-x-mark');
3234

3335
$this->requiresConfirmation();
3436

@@ -37,7 +39,7 @@ protected function setUp(): void
3739
$this->action(function (): void {
3840
$result = $this->process(static fn (Model $record) => $record->update(['approved_at' => now(), 'declined_at' => null]));
3941

40-
if (! $result) {
42+
if ( ! $result) {
4143
$this->failure();
4244

4345
return;

app/Filament/Actions/DeclinedAction.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace App\Filament\Actions;
46

57
use Filament\Actions\Concerns\CanCustomizeProcess;
6-
use Filament\Support\Facades\FilamentIcon;
78
use Illuminate\Database\Eloquent\Model;
89

9-
class DeclinedAction extends \Filament\Tables\Actions\Action
10+
final class DeclinedAction extends \Filament\Tables\Actions\Action
1011
{
1112
use CanCustomizeProcess;
13+
1214
public static function getDefaultName(): ?string
1315
{
1416
return 'declined';
@@ -28,7 +30,7 @@ protected function setUp(): void
2830

2931
$this->color('warning');
3032

31-
$this->icon( 'heroicon-s-check');
33+
$this->icon('heroicon-s-check');
3234

3335
$this->requiresConfirmation();
3436

@@ -37,7 +39,7 @@ protected function setUp(): void
3739
$this->action(function (): void {
3840
$result = $this->process(static fn (Model $record) => $record->update(['declined_at' => now(), 'approved_at' => null]));
3941

40-
if (! $result) {
42+
if ( ! $result) {
4143
$this->failure();
4244

4345
return;

app/Filament/Clusters/Articles.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace App\Filament\Clusters;
46

57
use Filament\Clusters\Cluster;
68

7-
class Articles extends Cluster
9+
final class Articles extends Cluster
810
{
911
protected static ?string $navigationIcon = 'heroicon-o-squares-2x2';
1012
}

app/Filament/Resources/ArticleResource.php

Lines changed: 30 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace App\Filament\Resources;
46

57
use App\Filament\Actions\ApprovedAction;
@@ -8,14 +10,13 @@
810
use App\Models\Article;
911
use Filament\Resources\Resource;
1012
use Filament\Tables;
13+
use Filament\Tables\Actions\ActionGroup;
1114
use Filament\Tables\Columns\TextColumn;
12-
use Filament\Tables\Table;
1315
use Filament\Tables\Filters\Filter;
16+
use Filament\Tables\Table;
1417
use Illuminate\Database\Eloquent\Builder;
15-
use Filament\Tables\Actions\ActionGroup;
16-
1718

18-
class ArticleResource extends Resource
19+
final class ArticleResource extends Resource
1920
{
2021
protected static ?string $model = Article::class;
2122

@@ -26,36 +27,36 @@ public static function table(Table $table): Table
2627
return $table
2728
->columns([
2829
TextColumn::make('title')
29-
->label('Titre')
30-
->sortable(),
30+
->label('Titre')
31+
->sortable(),
3132
TextColumn::make('status')
32-
->label('Status')
33-
->getStateUsing(function ($record) {
34-
if ($record->approved_at) {
35-
return 'Approuver';
36-
} elseif ($record->declined_at) {
37-
return 'Décliner';
38-
} elseif($record->submitted_at) {
39-
return 'Soumis';
40-
}
41-
})
42-
->colors([
43-
'success' => 'Approuver',
44-
'danger' => 'Décliner',
45-
'warning' => 'Soumis',
46-
])
47-
->badge(),
33+
->label('Status')
34+
->getStateUsing(function ($record) {
35+
if ($record->approved_at) {
36+
return 'Approuver';
37+
} elseif ($record->declined_at) {
38+
return 'Décliner';
39+
} elseif ($record->submitted_at) {
40+
return 'Soumis';
41+
}
42+
})
43+
->colors([
44+
'success' => 'Approuver',
45+
'danger' => 'Décliner',
46+
'warning' => 'Soumis',
47+
])
48+
->badge(),
4849
TextColumn::make('submitted_at')
49-
->label('Date de soumission')
50-
->dateTime(),
50+
->label('Date de soumission')
51+
->dateTime(),
5152
TextColumn::make('user.name')
52-
->label('Auteur')
53-
->sortable()
53+
->label('Auteur')
54+
->sortable(),
5455
])
5556
->filters([
56-
Filter::make('submitted_at')->query( fn (Builder $query) => $query->whereNotNull('submitted_at'))->label('Soumis'),
57-
Filter::make('declined_at')->query( fn (Builder $query) => $query->whereNotNull('declined_at'))->label('Décliner'),
58-
Filter::make('approved_at')->query( fn (Builder $query) => $query->whereNotNull('approved_at'))->label('Approuver')
57+
Filter::make('submitted_at')->query(fn (Builder $query) => $query->whereNotNull('submitted_at'))->label('Soumis'),
58+
Filter::make('declined_at')->query(fn (Builder $query) => $query->whereNotNull('declined_at'))->label('Décliner'),
59+
Filter::make('approved_at')->query(fn (Builder $query) => $query->whereNotNull('approved_at'))->label('Approuver'),
5960
])
6061

6162
->actions([

app/Filament/Resources/ArticleResource/Pages/ListArticles.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace App\Filament\Resources\ArticleResource\Pages;
46

57
use App\Filament\Resources\ArticleResource;
6-
use Filament\Actions;
78
use Filament\Resources\Pages\ListRecords;
8-
use Filament\Tables\Actions\DeleteAction;
99

10-
class ListArticles extends ListRecords
10+
final class ListArticles extends ListRecords
1111
{
1212
protected static string $resource = ArticleResource::class;
1313

app/Models/Article.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,11 @@ public function getRouteKeyName(): string
7575
return 'slug';
7676
}
7777

78-
7978
public function user(): BelongsTo
8079
{
8180
return $this->belongsTo(User::class);
8281
}
8382

84-
85-
8683
public function excerpt(int $limit = 110): string
8784
{
8885
return Str::limit(strip_tags((string) md_to_html($this->body)), $limit);

tests/Feature/Filament/ArticleTest.php

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
declare(strict_types=1);
44

5-
use App\Filament\Actions\ApprovedAction;
6-
use App\Filament\Actions\DeclinedAction;
75
use App\Filament\Resources\ArticleResource;
86
use App\Models\Article;
97
use Filament\Tables\Actions\DeleteAction;
@@ -12,26 +10,26 @@
1210
beforeEach(function (): void {
1311
$this->user = $this->login();
1412
$this->articles = Article::factory()->count(10)->create([
15-
'submitted_at' => now()
13+
'submitted_at' => now(),
1614
]);
1715
});
1816

1917
describe(ArticleResource::class, function (): void {
2018

21-
it('page can display table with records', function () {
19+
it('page can display table with records', function (): void {
2220
Livewire::test(ArticleResource\Pages\ListArticles::class)
2321
->assertCanSeeTableRecords($this->articles);
2422
});
2523

26-
it('table can render columns', function () {
24+
it('table can render columns', function (): void {
2725
Livewire::test(ArticleResource\Pages\ListArticles::class)
2826
->assertCanRenderTableColumn('title')
2927
->assertCanRenderTableColumn('status')
3028
->assertCanRenderTableColumn('status')
3129
->assertCanRenderTableColumn('submitted_at');
3230
});
3331

34-
it('admin user can approved article', function () {
32+
it('admin user can approved article', function (): void {
3533
$article = Article::factory()->create(['submitted_at' => now()]);
3634

3735
Livewire::test(ArticleResource\Pages\ListArticles::class)
@@ -47,12 +45,11 @@
4745
->toBe(null);
4846
});
4947

50-
51-
it('admin user can declined article', function () {
48+
it('admin user can declined article', function (): void {
5249
$article = Article::factory()->create(['submitted_at' => now()]);
5350

5451
Livewire::test(ArticleResource\Pages\ListArticles::class)
55-
->callTableAction('declined', $article);
52+
->callTableAction('declined', $article);
5653

5754
$article->refresh();
5855

0 commit comments

Comments
 (0)