fix: audit sqlx_postgres::types::array for bad casts

abonander · abonander · commit 2cb621715a3f · 2024-08-16T17:30:55.000-07:00
diff --git a/sqlx-postgres/src/types/array.rs b/sqlx-postgres/src/types/array.rs
@@ -174,7 +174,14 @@ where
             }
         }
 
-        buf.extend(&(self.len() as i32).to_be_bytes()); // len
+        let array_len = i32::try_from(self.len()).map_err(|_| {
+            format!(
+                "encoded array length is too large for Postgres: {}",
+                self.len()
+            )
+        })?;
+
+        buf.extend(array_len.to_be_bytes()); // len
         buf.extend(&1_i32.to_be_bytes()); // lower bound
 
         for element in self.iter() {

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,14 @@ where`
`174`	`174`	`}`
`175`	`175`	`}`
`176`	`176`
`177`		`- buf.extend(&(self.len() as i32).to_be_bytes()); // len`
	`177`	`+ let array_len = i32::try_from(self.len()).map_err(\|_\| {`
	`178`	`+ format!(`
	`179`	`+ "encoded array length is too large for Postgres: {}",`
	`180`	`+ self.len()`
	`181`	`+ )`
	`182`	`+ })?;`
	`183`	`+`
	`184`	`+ buf.extend(array_len.to_be_bytes()); // len`
`178`	`185`	`buf.extend(&1_i32.to_be_bytes()); // lower bound`
`179`	`186`
`180`	`187`	`for element in self.iter() {`