Skip to content

Provide a replace_arguments dual to `take_arguments #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lu-zero opened this issue Apr 23, 2025 · 0 comments · May be fixed by #3842
Open

Provide a replace_arguments dual to `take_arguments #3839

lu-zero opened this issue Apr 23, 2025 · 0 comments · May be fixed by #3842
Labels
enhancement New feature or request

Comments

@lu-zero
Copy link

lu-zero commented Apr 23, 2025

I have found these related issues/pull requests

I did not create an issue regarding having a mean to run explain before running a query, but I can prepare one

Description

It should allow to take_arguments from a query, use it in another query and put them back.

It makes simpler to have a non-destructive way to run EXPLAIN over already built queries before executing them.

Prefered solution

Adding the replace_arguments call to a companion trait and implement it on Query and related structs would be simple enough, I can provide a PR if you deem it acceptable.

Is this a breaking change? Why or why not?

If it is implemented as companion trait it wouldn't break anything.
@lu-zero lu-zero added the enhancement New feature or request label Apr 23, 2025
lu-zero added a commit to lu-zero/sqlx that referenced this issue Apr 24, 2025
@lu-zero
feat: Add ExecuteEx::replace_arguments
01b7229 
Addresses launchbadge#3839
@lu-zero lu-zero linked a pull request Apr 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add ExecuteEx::replace_arguments lu-zero/sqlx
1 participant
@lu-zero