Skip to content

Smol+async global executor 1.80 dev #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Smol+async global executor 1.80 dev #3791

wants to merge 30 commits into from

Conversation

martin-kolarik
Copy link

async-global-executor added as the fourth executor. The PR extends PR #3790.

This is a breaking change -- async-global-executor has MSRV 1.80, therefore sqlx will have to be upgraded too.

@martin-kolarik
Sqlx-core: rename async_io dependency for async-std
fb3f254
@martin-kolarik
Sqlx-core: simplify TimeoutError
31553e7
@martin-kolarik
Sqlx-core: code for async-global-executor
0c12744
@martin-kolarik
Sqlx: integrate async-global-executor feature
6c324b1
@martin-kolarik
Merge with upstream
46f8400
@martin-kolarik
Note to unsafe
40f3d8d
@martin-kolarik
Step up MSRV as async-global-executor needs it
375b493
@martin-kolarik
Sqlx-core: fix of unix socket build
aef441b
@martin-kolarik
Unsafe fixes, smol executor added
f5e374a
@martin-kolarik
Workflow fix
7de5718
@martin-kolarik
Changes outside sqlx_rt
b462f43
@martin-kolarik
Cleanup conditional rt compilation
4f851b0
@martin-kolarik
Warning
4eadb24
@martin-kolarik
Merge branch 'temp'
dd053e1 
# Conflicts:
#	.github/workflows/sqlx.yml
@martin-kolarik
Add executors to test matrix
aa29a3e
@martin-kolarik
Fix of skipping code sqlite due to mismatch in cargo feature names
89faf0e
@martin-kolarik
Merge remote-tracking branch 'origin/sqlx-cli-sqlite-create-WAL-db-fix'
8cc0f5c
@martin-kolarik
Smol executor isolated
ddcf4ed
@martin-kolarik
Fix, reduce number of tests, remove async_std
653152a
@martin-kolarik
Fix of test_block_on, regression
d1e91f6
@martin-kolarik
Format fixes
5627ca8
@martin-kolarik
async-global-executor added
c7fa793
@abonander
Copy link
Collaborator

I would prefer to deprecate async-std for a release cycle before deleting it. Just cause it's discontinued doesn't mean people will stop using it immediately, especially because its constituent crates will continue to receive updates.

@martin-kolarik
Copy link
Author

I would prefer to deprecate async-std for a release cycle before deleting it. Just cause it's discontinued doesn't mean people will stop using it immediately, especially because its constituent crates will continue to receive updates.

Sure, I did not remove async_std from the sources, for the same reason.

@abonander abonander added the breaking:MSRV Requires waiting for an MSRV bump (see FAQ.md) label Apr 11, 2025
abonander
abonander reviewed Apr 12, 2025
View reviewed changes
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same note as here: #3790 (review)

@martin-kolarik martin-kolarik force-pushed the smol+async-global-executor-1.80-dev branch from 1f43f07 to 8d6377b Compare April 13, 2025 11:39
@martin-kolarik martin-kolarik force-pushed the smol+async-global-executor-1.80-dev branch from 8c2c83c to 9b0cebb Compare April 13, 2025 13:50
@martin-kolarik martin-kolarik force-pushed the smol+async-global-executor-1.80-dev branch from 35237ac to c3e8f61 Compare April 13, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonander abonander abonander left review comments

Assignees
No one assigned
Labels
breaking:MSRV Requires waiting for an MSRV bump (see FAQ.md)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-kolarik @abonander