Skip to content

chore(postgres): update rand to 0.9.0 #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryanseipp
Copy link

Does your PR solve an issue?

No linked issues, but resolves duplicate versions of rand and its dependent crates for me.

Is this a breaking change?

No. sqlx-postgres does not export the types of rand, and sasl connection behavior should be equivalent after this upgrade.

Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other places in the project (namely the examples) that also use rand. Can you please update those as well?

@abonander
Copy link
Collaborator

However, there's also this issue: #3931 (comment)

@ryanseipp
Copy link
Author

However, there's also this issue: #3931 (comment)

If we want to wait until we can update across the board, we'll have to wait for those RustCrypto crates to be updated, as sqlx-mysql depends on rsa which depends on rand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants