refactor: tweaks after #3791 #4022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* restore fallback to `async-io` for `connect_tcp()` when `runtime-tokio` feature is enabled * `smol` and `async-global-executor` both use `async-task`, so `JoinHandle` impls can be consolidated * no need for duplicate `yield_now()` impls * delete `impl Socket for ()`
JosiahParry
pushed a commit
to JosiahParry/sqlx
that referenced
this pull request
Sep 24, 2025
* restore fallback to `async-io` for `connect_tcp()` when `runtime-tokio` feature is enabled * `smol` and `async-global-executor` both use `async-task`, so `JoinHandle` impls can be consolidated * no need for duplicate `yield_now()` impls * delete `impl Socket for ()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async-ioforconnect_tcp()whenruntime-tokiofeature is enabledsmolandasync-global-executorboth useasync-task, soJoinHandleimpls can be consolidatedyield_now()implsimpl Socket for ()