Exclude directories with changed .go files which aren't returned by go list

Author: rengawm

find-affected-packages.go

@@ -33,8 +33,10 @@ func main() {
 func calcAffectedPackages(localPackagesToDeps packagesToDepMap, changedLocalPackages, changedModules []string) []string {
 	affectedPackageMap := make(map[string]bool)
 	for _, pkg := range changedLocalPackages {
-		// Any directly changed package is affected (obviously)
-		affectedPackageMap[pkg] = true
+		if _, ok := localPackagesToDeps[pkg]; ok {
+			// Any directly changed package is affected, as long as it came back from `go list <filterPackages>`
+			affectedPackageMap[pkg] = true
+		}
 
 		// Add all packages which depend on this changed package (including indirectly)
 		for pkgPath, pkgDeps := range localPackagesToDeps {

find-affected-packages_test.go

@@ -26,7 +26,10 @@ func TestCalcAffectedPackages(t *testing.T) {
 			"github.com/orgA/repoA/subPkg3": true,
 		},
 	}
-	changedLocalPackages := []string{"github.com/orgA/repoA/subPkg3"}
+	changedLocalPackages := []string{
+		"github.com/orgA/repoA/subPkg3",
+		"github.com/orgA/repoA/notRealPkg", // To simulate cases where we see a .go file changed somewhere that isn't a package go list returned
+	}
 	changedModules := []string{"github.com/orgB/repoB"}
 
 	affectedPackages := calcAffectedPackages(packagesToDeps, changedLocalPackages, changedModules)