feat(components): add HoverTrigger
#1698
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 566f63e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Size Change: +2.62 kB (+0.5%) Total Size: 528 kB
ℹ️ View Unchanged
|
| const { delay = 500, closeDelay = 250 } = props; | ||
|
|
||
| const state = { | ||
| ...useTooltipTriggerState({ delay, closeDelay, ...props }), |
There was a problem hiding this comment.
Since we expose closeDelay here, I think I'd expect to see openDelay instead of delay. Or maybe both? If delay is defined it overrides *Delay? Wdyt?
There was a problem hiding this comment.
The API is from RAC. delay is their version of "openDelay".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
HoverTrigger. Inspired by https://ui.shadcn.com/docs/components/hover-card