remove getelement nuw flag from pointer arithmetic; too aggresive

Author: kubo39

gen/binops.cpp

@@ -116,16 +116,7 @@ DValue *emitPointerOffset(Loc loc, DValue *base, Expression *offset,
   if (!llResult) {
     if (negateOffset)
       llOffset = gIR->ir->CreateNeg(llOffset);
-#if LDC_LLVM_VER >= 2000
-      llvm::GEPNoWrapFlags nw = llvm::GEPNoWrapFlags::inBounds();
-      if (!negateOffset)
-        nw |= llvm::GEPNoWrapFlags::noUnsignedWrap();
-#endif
-    llResult = DtoGEP1(llBaseTy, llBase, llOffset
-#if LDC_LLVM_VER >= 2000
-                    , "", nullptr, nw
-#endif
-    );
+    llResult = DtoGEP1(llBaseTy, llBase, llOffset);
   }
 
   return new DImValue(resultType, llResult);

gen/toir.cpp

@@ -1534,16 +1534,7 @@ class ToElemVisitor : public Visitor {
       assert(e->e2->op == EXP::int64);
       LLConstant *offset =
           e->op == EXP::plusPlus ? DtoConstUint(1) : DtoConstInt(-1);
-#if LDC_LLVM_VER >= 2000
-      auto nw = llvm::GEPNoWrapFlags::inBounds();
-      if (e->op == EXP::plusPlus)
-        nw |= llvm::GEPNoWrapFlags::noUnsignedWrap();
-#endif
-      post = DtoGEP1(DtoMemType(dv->type->nextOf()), val, offset, "", p->scopebb()
-#if LDC_LLVM_VER >= 2000
-                   , nw
-#endif
-      );
+      post = DtoGEP1(DtoMemType(dv->type->nextOf()), val, offset, "", p->scopebb());
     } else if (e1type->isComplex()) {
       assert(e2type->isComplex());
       LLValue *one = LLConstantFP::get(DtoComplexBaseType(e1type), 1.0);

tests/codegen/inbounds.d

@@ -30,21 +30,21 @@ int foo3(int* p, int i) {
 // PostExp in pointer
 // CHECK-LABEL: @foo4
 int foo4(int* p) {
-    // CHECK: getelementptr inbounds{{( nuw)?}}
+    // CHECK: getelementptr inbounds
     return *p++;
 }
 
 // PreExp in pointer
 // CHECK-LABEL: @foo5
 int foo5(int* p) {
-    // CHECK: getelementptr inbounds{{( nuw)?}}
+    // CHECK: getelementptr inbounds
     return *++p;
 }
 
 // Add offset to pointer
 // CHECK-LABEL: @foo6
 int foo6(int* p, int i) {
-    // CHECK: getelementptr inbounds{{( nuw)?}}
+    // CHECK: getelementptr inbounds
     return *(p + i);
 }