Skip to content

Conversation

@jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Oct 14, 2025

Add some lemmas that angles involving orthogonal projections are right angles. The unoriented versions abstract something used multiple times in Mathlib.Geometry.Euclidean.Angle.Bisector (which is thus refactored to use the new lemmas); I expect the oriented versions may be of use in future in further oriented angle bisection lemmas building on top of #30477.


Open in Gitpod

Add some lemmas that angles involving orthogonal projections are right
angles.  The unoriented versions abstract something used multiple
times in `Mathlib.Geometry.Euclidean.Angle.Bisector` (which is thus
refactored to use the new lemmas); I expect the oriented versions may
be of use in future in further oriented angle bisection lemmas
building on top of leanprover-community#30477.
@jsm28 jsm28 added the t-euclidean-geometry Affine and axiomatic geometry label Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

PR summary 57f5895e92

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Geometry.Euclidean.Angle.Bisector 1
Mathlib.Geometry.Euclidean.Angle.Unoriented.Projection (new file) 2065
Mathlib.Geometry.Euclidean.Angle.Oriented.Projection (new file) 2131

Declarations diff

+ angle_orthogonalProjection_self
+ angle_self_orthogonalProjection
+ oangle_orthogonalProjection_self
+ oangle_self_orthogonalProjection
+ two_zsmul_oangle_orthogonalProjection_self
+ two_zsmul_oangle_self_orthogonalProjection

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 27, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 27, 2025
…30522)

Add some lemmas that angles involving orthogonal projections are right angles.  The unoriented versions abstract something used multiple times in `Mathlib.Geometry.Euclidean.Angle.Bisector` (which is thus refactored to use the new lemmas); I expect the oriented versions may be of use in future in further oriented angle bisection lemmas building on top of #30477.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 27, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Geometry/Euclidean/Angle): angles with orthogonal projections [Merged by Bors] - feat(Geometry/Euclidean/Angle): angles with orthogonal projections Oct 27, 2025
@mathlib-bors mathlib-bors bot closed this Oct 27, 2025
@jsm28 jsm28 deleted the angle_projection branch October 27, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-euclidean-geometry Affine and axiomatic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants