Skip to content

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Oct 19, 2025

Extracted from #30658. Found by extending the commandStart linter to proof bodies.


Open in Gitpod

Extracted from leanprover-community#30658. Found by extending the commandStart linter to proof bodies.
@github-actions github-actions bot added the t-order Order theory label Oct 19, 2025
@github-actions
Copy link

PR summary 7c64d37d34

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator Author

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work, Damiano. I like all changes which are not related to removing a space before not, but am on the fence about most of those. Let me split this PR in two, and bors r+ the "good" half.

@grunweg
Copy link
Collaborator Author

grunweg commented Oct 21, 2025

#30762 is the good subset, which I've just borsed

@JovanGerb
Copy link
Collaborator

I agree that for the spacing after not, there is no clear consensus on what is the preferred form. I'd like it if we picked one style and applied it consistently. But maybe we should ask others what they think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants