Skip to content

Conversation

@themathqueen
Copy link
Collaborator

@themathqueen themathqueen commented Oct 19, 2025

We change _conjugate_ to _star_left_conjugate_ and _conjugate_' to _star_right_conjugate_ to avoid confusion since sometimes in some files it means _ * _ * star _ and in others it means star _ * _ * _.

In particular,

Algebra/Algebra/StrictPositivity:

  • IsUnit.isStrictlyPositive_conjugate_iff -> IsUnit.isStrictlyPositive_star_right_conjugate_iff
  • IsUnit.isStrictlyPositive_conjugate_iff' -> IsUnit.isStrictlyPositive_star_left_conjugate_iff

Algebra/Order/Star/Basic:

  • conjugate_nonnneg -> star_left_conjugate_nonneg
  • conjugate_nonneg' -> star_right_conjugate_nonneg
  • conjugate_le_conjugate -> star_left_conjugate_le_conjugate
  • conjugate_le_conjugate' -> star_right_conjugate_le_conjugate
  • conjugate_lt_conjugate -> star_left_conjugate_lt_conjugate
  • conjugate_lt_conjugate' -> star_right_conjugate_lt_conjugate
  • conjugate_pos -> star_left_conjugate_pos
  • conjugate_pos' -> star_right_conjugate_pos
  • IsUnit.conjugate_nonneg_iff -> IsUnit.star_right_conjugate_nonneg_iff
  • IsUnit.conjugate_nonneg_iff' -> IsUnit.star_left_conjugate_nonneg_iff

Analysis/CStarAlgebra/CFC/Order:

  • CStarAlgebra.conjugate_le_norm_smul -> CStarAlgebra.star_left_conjugate_le_norm_smul
  • CStarAlgebra.conjugate_le_norm_smul' -> CStarAlgebra.star_right_conjugate_le_norm_smul

LinearAlgebra/Matrix/PosDef:

  • Matrix.IsUnit.posSemidef_conjugate_iff -> Matrix.IsUnit.posSemidef_star_right_conjugate_iff
  • Matrix.IsUnit.posSemidef_conjugate_iff' -> Matrix.IsUnit.posSemidef_star_left_conjugate_iff
  • Matrix.IsUnit.posDef_conjugate_iff -> Matrix.IsUnit.posDef_star_right_conjugate_iff
  • Matrix.IsUnit.posDef_conjugate_iff' -> Matrix.IsUnit.posDef_star_left_conjugate_iff

There are more to do, but will leave this for another PR.

Open in Gitpod

@github-actions
Copy link

github-actions bot commented Oct 19, 2025

PR summary 32bd6c7c8c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsUnit.posSemidef_star_left_conjugate_iff
+ IsUnit.posSemidef_star_right_conjugate_iff
+ IsUnit.star_left_conjugate_nonneg_iff
+ IsUnit.star_right_conjugate_nonneg_iff
+ _root_.IsUnit.isStrictlyPositive_star_left_conjugate_iff
+ _root_.IsUnit.isStrictlyPositive_star_right_conjugate_iff
+ _root_.Matrix.IsUnit.posDef_star_left_conjugate_iff
+ _root_.Matrix.IsUnit.posDef_star_right_conjugate_iff
+ star_left_conjugate_le_conjugate
+ star_left_conjugate_le_norm_smul
+ star_left_conjugate_lt_conjugate
+ star_left_conjugate_nonneg
+ star_left_conjugate_pos
+ star_right_conjugate_le_conjugate
+ star_right_conjugate_le_norm_smul
+ star_right_conjugate_lt_conjugate
+ star_right_conjugate_nonneg
+ star_right_conjugate_pos
- IsUnit.conjugate_nonneg_iff
- IsUnit.conjugate_nonneg_iff'
- IsUnit.posSemidef_conjugate_iff
- IsUnit.posSemidef_conjugate_iff'
- _root_.IsUnit.isStrictlyPositive_conjugate_iff
- _root_.IsUnit.isStrictlyPositive_conjugate_iff'
- _root_.Matrix.IsUnit.posDef_conjugate_iff
- _root_.Matrix.IsUnit.posDef_conjugate_iff'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 19, 2025
@themathqueen
Copy link
Collaborator Author

@j-loreaux, I also renamed CStarAlgebra.conjugate_le_norm_smul to match this way, but I can change it back if you want.

@themathqueen themathqueen marked this pull request as ready for review October 19, 2025 19:08
@themathqueen themathqueen changed the title chore(Algebra/Order/Star/Basic): rename **conjugate to **conjugate' chore(Algebra/Order/Star/Basic): rename **conjugate** to **conjugate**' Oct 19, 2025
@j-loreaux
Copy link
Collaborator

I wonder if we can do even better regarding naming in this regard. Perhaps star _ * _ * _ could be star_conjugate (or star_left_conjugate) and other could be conjugate_star (or star_right_conjugate).

@themathqueen
Copy link
Collaborator Author

I like the star_left_conjugate and the star_right_conjugate! Makes it very clear.

@themathqueen themathqueen added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 20, 2025
@themathqueen themathqueen changed the title chore(Algebra/Order/Star/Basic): rename **conjugate** to **conjugate**' chore(Algebra/Order/Star/Basic): rename **conjugate** to **star_left_conjugate** Oct 20, 2025
@themathqueen themathqueen removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 20, 2025
@themathqueen themathqueen changed the title chore(Algebra/Order/Star/Basic): rename **conjugate** to **star_left_conjugate** chore(Algebra/Order/Star/Basic): rename conjugate** to star_left_conjugate** Oct 20, 2025
@themathqueen themathqueen changed the title chore(Algebra/Order/Star/Basic): rename conjugate** to star_left_conjugate** chore: rename conjugate** to star_left_conjugate** Oct 20, 2025
@themathqueen themathqueen changed the title chore: rename conjugate** to star_left_conjugate** chore: rename **conjugate** to **star_left_conjugate** Oct 20, 2025
@themathqueen themathqueen added the t-analysis Analysis (normed *, calculus) label Oct 20, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 23, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 23, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 23, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants