-
Notifications
You must be signed in to change notification settings - Fork 846
chore: rename **conjugate** to **star_left_conjugate** #30692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: rename **conjugate** to **star_left_conjugate** #30692
Conversation
PR summary 32bd6c7c8cImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
@j-loreaux, I also renamed |
|
I wonder if we can do even better regarding naming in this regard. Perhaps |
|
I like the |
cbe9f39 to
0809a89
Compare
a2746ef to
d203244
Compare
|
This pull request has conflicts, please merge |
|
This pull request has conflicts, please merge |
We change
_conjugate_to_star_left_conjugate_and_conjugate_'to_star_right_conjugate_to avoid confusion since sometimes in some files it means_ * _ * star _and in others it meansstar _ * _ * _.In particular,
Algebra/Algebra/StrictPositivity:IsUnit.isStrictlyPositive_conjugate_iff->IsUnit.isStrictlyPositive_star_right_conjugate_iffIsUnit.isStrictlyPositive_conjugate_iff'->IsUnit.isStrictlyPositive_star_left_conjugate_iffAlgebra/Order/Star/Basic:conjugate_nonnneg->star_left_conjugate_nonnegconjugate_nonneg'->star_right_conjugate_nonnegconjugate_le_conjugate->star_left_conjugate_le_conjugateconjugate_le_conjugate'->star_right_conjugate_le_conjugateconjugate_lt_conjugate->star_left_conjugate_lt_conjugateconjugate_lt_conjugate'->star_right_conjugate_lt_conjugateconjugate_pos->star_left_conjugate_posconjugate_pos'->star_right_conjugate_posIsUnit.conjugate_nonneg_iff->IsUnit.star_right_conjugate_nonneg_iffIsUnit.conjugate_nonneg_iff'->IsUnit.star_left_conjugate_nonneg_iffAnalysis/CStarAlgebra/CFC/Order:CStarAlgebra.conjugate_le_norm_smul->CStarAlgebra.star_left_conjugate_le_norm_smulCStarAlgebra.conjugate_le_norm_smul'->CStarAlgebra.star_right_conjugate_le_norm_smulLinearAlgebra/Matrix/PosDef:Matrix.IsUnit.posSemidef_conjugate_iff->Matrix.IsUnit.posSemidef_star_right_conjugate_iffMatrix.IsUnit.posSemidef_conjugate_iff'->Matrix.IsUnit.posSemidef_star_left_conjugate_iffMatrix.IsUnit.posDef_conjugate_iff->Matrix.IsUnit.posDef_star_right_conjugate_iffMatrix.IsUnit.posDef_conjugate_iff'->Matrix.IsUnit.posDef_star_left_conjugate_iffThere are more to do, but will leave this for another PR.