Skip to content

Conversation

themathqueen
Copy link
Collaborator

@themathqueen themathqueen commented Oct 19, 2025

Also generalize one InnerProductSpace to Module and move section to earlier file.


Open in Gitpod

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Oct 19, 2025
@themathqueen themathqueen added easy < 20s of review time. See the lifecycle page for guidelines. and removed t-analysis Analysis (normed *, calculus) labels Oct 19, 2025
Copy link

github-actions bot commented Oct 19, 2025

PR summary d95168ed4d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.OrthonormalBasis.toBasis_mulOpposite

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 19, 2025

✌️ themathqueen can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Oct 19, 2025
@eric-wieser eric-wieser added the t-analysis Analysis (normed *, calculus) label Oct 19, 2025
@themathqueen
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Oct 20, 2025
…> `SeminormedAddCommGroup` (#30695)

Also generalize one `InnerProductSpace` to `Module` and move section to earlier file.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 20, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis/InnerProductSpace/MulOpposite): NormedAddCommGroup -> SeminormedAddCommGroup [Merged by Bors] - chore(Analysis/InnerProductSpace/MulOpposite): NormedAddCommGroup -> SeminormedAddCommGroup Oct 20, 2025
@mathlib-bors mathlib-bors bot closed this Oct 20, 2025
@themathqueen themathqueen deleted the inner_op_chore branch October 20, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants