Skip to content

Conversation

@joelriou
Copy link
Collaborator

@joelriou joelriou commented Oct 19, 2025

@joelriou joelriou added t-order Order theory WIP Work in progress labels Oct 19, 2025
@github-actions
Copy link

github-actions bot commented Oct 19, 2025

PR summary c53d34d21e

Import changes exceeding 2%

% File
+38.58% Mathlib.Order.Category.PartOrdEmb

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Order.Category.PartOrdEmb 464 643 +179 (+38.58%)
Import changes for all files
Files Import difference
Mathlib.Order.Category.PartOrdEmb 179

Declarations diff

+ CoconePt
+ CoconePt.desc
+ CoconePt.fac_apply
+ Hom.le_iff_le
+ cocone
+ instance : HasColimit F
+ instance : HasColimitsOfShape J PartOrdEmb.{u}
+ instance : HasFilteredColimitsOfSize.{u, u} PartOrdEmb.{u}
+ instance : PartialOrder (CoconePt hc)
+ instance : PreservesColimit F (forget _)
+ instance : PreservesColimitsOfShape J (forget PartOrdEmb.{u})
+ instance : PreservesFilteredColimitsOfSize.{u, u} (forget PartOrdEmb.{u})
+ isColimitCocone
+ jointly_surjective_of_isColimit₂

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 19, 2025
@joelriou joelriou changed the title feat(Order/Category): PardOrdEmb has filtering colimits feat(Order/Category): PardOrdEmb has filtered colimits Oct 20, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 29, 2025
@mathlib4-dependent-issues-bot
Copy link
Collaborator

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 29, 2025
@joelriou joelriou removed the WIP Work in progress label Oct 29, 2025
Copy link
Collaborator

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the most minor golf suggestion.

Thanks!
maintainer delegate

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 14, 2025
@robin-carlier robin-carlier changed the title feat(Order/Category): PardOrdEmb has filtered colimits feat(Order/Category): PartOrdEmb has filtered colimits Nov 14, 2025
@Vierkantor Vierkantor assigned kim-em and unassigned Vierkantor Nov 14, 2025
Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Nov 16, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 16, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order/Category): PartOrdEmb has filtered colimits [Merged by Bors] - feat(Order/Category): PartOrdEmb has filtered colimits Nov 16, 2025
@mathlib-bors mathlib-bors bot closed this Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants