Skip to content

Conversation

themathqueen
Copy link
Collaborator

@themathqueen themathqueen commented Oct 19, 2025

unitary.spectrum.unitary_conjugate and unitary.spectrum.unitary_conjugate' should be in the _root_ namespace since they already have unitary in their name. We also rename them to spectrum.unitary_star_conjugate_left and spectrum.unitary_star_conjugate_right to match the renaming convention in #30692.


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 19, 2025
Copy link

github-actions bot commented Oct 19, 2025

PR summary d95168ed4d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.spectrum.unitary_star_left_conjugate
+ _root_.spectrum.unitary_star_right_conjugate

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@themathqueen themathqueen added the easy < 20s of review time. See the lifecycle page for guidelines. label Oct 19, 2025
@themathqueen themathqueen changed the title chore(Algebra/Star/Unitary): fix lemma names chore(Algebra/Star/Unitary): rename unitary.spectrum.unitary_conjugate Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant