Skip to content

Conversation

eric-wieser
Copy link
Member


Open in Gitpod

@eric-wieser eric-wieser requested a review from JovanGerb October 19, 2025 22:29
@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. t-analysis Analysis (normed *, calculus) labels Oct 19, 2025
@github-actions
Copy link

github-actions bot commented Oct 19, 2025

PR summary 8aa3ccd118

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ posLog_le_posLog

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@JovanGerb
Copy link
Collaborator

Thanks! I wonder why posLog_norm_add_le and posLog_add have the log 2 in a different place (and why posLog_add isn't called posLog_add_le), but that need not block this PR.

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by JovanGerb.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 20, 2025
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicher, thanks!
bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Oct 20, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 20, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis/SpecialFunctions/Log/PosLog): golf a proof using grw [Merged by Bors] - chore(Analysis/SpecialFunctions/Log/PosLog): golf a proof using grw Oct 20, 2025
@mathlib-bors mathlib-bors bot closed this Oct 20, 2025
@mathlib-bors mathlib-bors bot deleted the eric-wieser/posLog branch October 20, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants