Skip to content

Conversation

@tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Jan 29, 2026

This PR proves that associated elements have the same number of factors (this follows from the preceeding lemma factors_unique).


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Jan 29, 2026
@github-actions
Copy link

github-actions bot commented Jan 29, 2026

PR summary e56beffe25

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.Associated.card_factors_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 29, 2026
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 29, 2026

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 29, 2026
Co-authored-by: Johan Commelin <johan@commelin.net>
@tb65536 tb65536 added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 29, 2026
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 29, 2026
Co-authored-by: Johan Commelin <johan@commelin.net>
@tb65536 tb65536 added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 30, 2026
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 30, 2026
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 30, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 30, 2026
… have the same number of factors (#34572)

This PR proves that associated elements have the same number of factors (this follows from the preceeding lemma `factors_unique`).

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 30, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/UniqueFactorizationDomain/Basic): associated elements have the same number of factors [Merged by Bors] - feat(RingTheory/UniqueFactorizationDomain/Basic): associated elements have the same number of factors Jan 30, 2026
@mathlib-bors mathlib-bors bot closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants