-
Notifications
You must be signed in to change notification settings - Fork 26
feat: add Cslib/Computability/Languages/RegularLanguage.lean and associated changes #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ctchou
wants to merge
3
commits into
leanprover:main
Choose a base branch
from
ctchou:regular-language
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+264
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chenson2018: Looks like some linters have failed. How do I run them locally on my machine? |
These are from |
|
Thanks for the info. The linter failures should be fixed now. |
chenson2018
requested changes
Oct 31, 2025
eric-wieser
reviewed
Oct 31, 2025
eric-wieser
reviewed
Oct 31, 2025
eric-wieser
reviewed
Oct 31, 2025
eric-wieser
reviewed
Oct 31, 2025
|
Looks good to me now, minus the merge conflicts. |
af5523a to
71e4e21
Compare
|
Rebase on top of the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch proves the closure properties of regular languages under boolean operations. We first prove that
Language.IsRegular, which is defined in mathlib, can also be characterized using cslib's DFA and NFA. We then prove those closure properties usingCslib.DFA. The key idea is a product construction forDA, which allows us to prove that regular languages are closed under both union and intersection (calledaddandinfin Language). The definition ofDFA.mtris moved toDA.mtr, so that it can be applied toDAin general. Some miscellaneous properties aboutLanguageare also proved.The closure properties under concatenation and Kleene star will be proved later. They require some nontrivial work.
This PR depends on #135.