Skip to content

Conversation

@chenson2018
Copy link
Collaborator

Having the mergeWithGrind linter on by default causes two issues:

  • for performance, it means running each call to grind in duplicate
  • for maintainability, it requires many small changes in the nightly-testing branch

This linting is useful, but should be reinstated on a cron basis as Mathlib does.

@chenson2018
Copy link
Collaborator Author

!radar

@leanprover-radar
Copy link

leanprover-radar commented Nov 24, 2025

Benchmark results for 85bbc2c against b7c4fa0 are in! @chenson2018

Major changes (1)
  • build//instructions changed by -47.3% (✅).

@chenson2018
Copy link
Collaborator Author

As I expected, the performance benefit is concentrated in the lambda calculus files and is highly significant.

@fmontesi fmontesi merged commit ca6b90a into main Nov 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants