Skip to content

Commit b930cfc

Browse files
committed
Clarify goal of test with comment
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
1 parent f0800c4 commit b930cfc

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

test/test_subgroups.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -981,13 +981,10 @@ def test_parse_with_config_file_with_different_subgroup(
981981
args: str,
982982
expected: A1OrA2,
983983
):
984-
"""TODO: Honestly not 100% sure what I was testing here."""
985-
# I think I was trying to reproduce the issue from #276
986-
984+
"""Test the case where a subgroup different from the default is saved in the config file."""
987985
config_path = (tmp_path / "bob").with_suffix(filetype)
988986
save(value_in_config, config_path, save_dc_types=True)
989-
990-
assert parse(A1OrA2, config_path=config_path, args=args) == expected
987+
assert parse(type(value_in_config), config_path=config_path, args=args) == expected
991988

992989

993990
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)