Memory leak in FluentWindow

[thecco]

Describe the bug

A memory leak occurs in FluentWindow. The window instance and its DataContext are not collected by the GC because an anonymous delegate is subscribed to the static event ApplicationThemeManager.Changed without being unsubscribed. This results in a continuous increase in the EventHandler count.

To Reproduce

1. Create a Window class inheriting from FluentWindow and add a finalizer with a Debug.WriteLine to track its destruction:

public class TestWindow : FluentWindow
{
    ~TestWindow() 
    {
        Debug.WriteLine("Destruction");
    }
}

2. Open and close the TestWindow multiple times.
3. Perform a manual Garbage Collection (GC) and check the Output Window.
4. The finalizer is never called (the "Destruction" log does not appear), and the EventHandler count increases continuously in the memory profiler.

Expected behavior

When the window is closed, all event subscriptions—especially those to static events—should be released so the FluentWindow and its ViewModel can be garbage collected.

Screenshots

No response

OS version

Windows 11 25H2 26200.7462

.NET version

.NET9

WPF-UI NuGet version

4.20

Additional context

I have implemented a temporary workaround for this issue as follows

protected override void OnClosed(EventArgs e)
{
    base.OnClosed(e);

    FixBug();
}

private void FixBug()
{
    Type? type = typeof(ApplicationThemeManager);
    FieldInfo? eventField = type.GetField("Changed", BindingFlags.Static | BindingFlags.NonPublic | BindingFlags.Instance);

    if (eventField != null)
    {
        MulticastDelegate? eventDelegate = eventField.GetValue(null) as MulticastDelegate;

        if (eventDelegate != null)
        {
            Delegate[] invocationList = eventDelegate.GetInvocationList();

            foreach (Delegate handler in invocationList)
            {
                if (handler.Target == this)
                {
                    ApplicationThemeManager.Changed -= (ThemeChangedEvent)handler;
                }
            }
        }
    }
}

[Just-Doro]

Combining EventManager.RegisterClassHandler with ModuleInitializer enables global automatic cleanup.

/// <summary>
/// 全局监控器：自动为所有 FluentWindow 附加 Closed 事件， 关闭时通过反射移除在 ApplicationThemeManager
/// </summary>
public static class FluentWindowLeakMonitor
{
    private static bool _initialized;

    public static void Initialize()
    {
        if (_initialized) return;
        _initialized = true;

        // 为所有 FluentWindow 注册 Loaded 处理器
        EventManager.RegisterClassHandler(typeof(FluentWindow), FrameworkElement.LoadedEvent,
            new RoutedEventHandler(OnFluentWindowLoaded), true);
    }

    /// <summary>
    /// 在程序集模块加载时自动初始化：无需修改 App.xaml.cs
    /// </summary>
    [ModuleInitializer]
    public static void ModuleInit()
    {
        Initialize();
    }

    private static void OnFluentWindowLoaded(object sender, RoutedEventArgs e)
    {
        if (sender is not FluentWindow fw) return;

        // 确保只附加一次 Closed 处理器
        fw.Closed -= OnFluentWindowClosed;
        fw.Closed += OnFluentWindowClosed;
    }

    private static void OnFluentWindowClosed(object? sender, EventArgs e)
    {
        if (sender is not FluentWindow fw) return;

        CleanupAppThemeChangedHandle(fw);
    }

    private static void CleanupAppThemeChangedHandle(FluentWindow target)
    {
        Type type = typeof(ApplicationThemeManager);
        FieldInfo? eventField = type.GetField("Changed", BindingFlags.Static | BindingFlags.NonPublic | BindingFlags.Instance);

        if (eventField == null)
            return;

        MulticastDelegate? eventDelegate = eventField.GetValue(null) as MulticastDelegate;

        if (eventDelegate == null)
            return;

        foreach (Delegate handler in eventDelegate.GetInvocationList())
        {
            if (handler.Target == target)
            {
                try
                {
                    ApplicationThemeManager.Changed -= (ThemeChangedEvent)handler;
                }
                catch
                {
                }
            }
        }
    }
}