feat(controls): Add TitleBar CenterContent property
#1484
+35
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimizing changes
github-actions
bot
added
controls
This was referenced Jul 15, 2025
pomianowski
changed the title
TitleBar CenterContent property
Merge 2025-11-12 from base repo
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a CenterContent property to the TitleBar control, enabling developers to place content in the center area of the title bar.
Key changes:
- New
CenterContentdependency property with getter/setter - Updated XAML template with additional grid column for centered content
- Enhanced mouse hit-testing logic to handle center content interactions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Wpf.Ui/Controls/TitleBar/TitleBar.cs | Added CenterContent dependency property and updated window procedure hook to handle mouse-over detection for center content |
| src/Wpf.Ui/Controls/TitleBar/TitleBar.xaml | Added new grid column and ContentPresenter for center content, reordered existing columns |
Comment on lines
705
to
719
| if (message == PInvoke.WM_NCHITTEST) | ||
| { | ||
| if (TrailingContent is UIElement || Header is UIElement || CenterContent is UIElement) | ||
| { | ||
| UIElement? headerLeftUIElement = Header as UIElement; | ||
| UIElement? headerCenterUIElement = CenterContent as UIElement; | ||
| UIElement? headerRightUiElement = TrailingContent as UIElement; | ||
|
|
||
| var e = new HwndProcEventArgs(hwnd, msg, wParam, lParam, isMouseOverHeaderContent); | ||
| WndProcInvoked?.Invoke(this, e); | ||
| isMouseOverHeaderContent = (headerLeftUIElement is not null && headerLeftUIElement != _titleBlock && headerLeftUIElement.IsMouseOverElement(lParam)) | ||
| || (headerCenterUIElement?.IsMouseOverElement(lParam) ?? false) | ||
| || (headerRightUiElement?.IsMouseOverElement(lParam) ?? false); | ||
| } | ||
|
|
||
| if (e.ReturnValue != null) | ||
| { | ||
| handled = e.Handled; | ||
| return e.ReturnValue ?? IntPtr.Zero; | ||
| } | ||
| htResult = GetWindowBorderHitTestResult(hwnd, lParam); | ||
| } |
There was a problem hiding this comment.
Tabs are used for indentation instead of spaces. According to the project's .editorconfig, C# files should use spaces (indent_style = space). Please replace tabs with spaces for consistent formatting.
| } | ||
|
|
||
| switch (message) | ||
| switch (message) |
There was a problem hiding this comment.
Tab used for indentation instead of spaces. According to the project's .editorconfig, C# files should use spaces (indent_style = space). Please replace the tab with spaces.
Suggested change
| switch (message) | |
| switch (message) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fix for #1483
It adds a
CenterContentDependencyProperty and a new column in the Grid of TitleBar, making developer able to put content in the center area of the titlebar.Moreover, with
HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}"we make developer able to align the centered area more precisely, to the left, center or right edge.Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently there are few, less obvious alternatives.
Issue Number: #1483
What is the new behavior?
Devs are now able to put content directly in the centered area of the title bar.